Repository navigation
Clear request queue and reconnection callbacks upon sign out - #13393
Conversation
|
@Santhosh-Sellavel @PauloGasparSv One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@luacmartins @MariaHCD Are we fine with this Is this considered as a test pass, after logout no API failed with 403 or the session expired?Screen.Recording.2022-12-07.at.10.05.06.PM.mov |
| * Delete all queued reconnection callbacks | ||
| */ | ||
| function clearReconnectionCallbacks() { | ||
| _.each(_.keys(reconnectionCallbacks), key => delete reconnectionCallbacks[key]); |
There was a problem hiding this comment.
NAB We could also change const reconnectionCallbacks = {} to let reconnectionCallbacks = {} and then assign it to an empty object here.
| _.each(_.keys(reconnectionCallbacks), key => delete reconnectionCallbacks[key]); | |
| reconnectionCallbacks = {}; |
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - ChromeN/A Mobile Web - SafariN/A Desktopdesktop.moviOSN/A AndroidN/A |
|
@luacmartins bump on this #13393 (comment) |
|
@Santhosh-Sellavel that 403 seems to be unrelated to these changes. Is that consistently failing for you? Does that happen on main too? |
PauloGasparSv
left a comment
There was a problem hiding this comment.
LGTM! Great fix :D
Web
Screen.Recording.2022-12-07.at.14.54.52.mov
Mobile Web - Chrome
N/A
Mobile Web - Safari
N/A
Desktop
Screen.Recording.2022-12-07.at.15.04.16.mov
iOS
N/A
Android
N/A
Just tested main and I didn't see the request. No idea what it is but looks harmless right? I think we can approve @Santhosh-Sellavel : ) |
Yes Consistently occurs for me on the main too. Irrelevant here then, approving shortly after filling my checklist! |
Reviewer Checklist
Screenshots/VideosWebWEB_ClearReq.movDesktopScreen.Recording.2022-12-07.at.11.51.14.PM.mov |
Santhosh-Sellavel
left a comment
There was a problem hiding this comment.
LGTM Tests well!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by @chiragsalian in version: 1.2.38-6 🚀
|
Details
Fixed Issues
$ #11850 (Second part of the solution here)
PROPOSAL: GH_LINK_ISSUE(COMMENT)
Tests
Session expiredOffline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*filesWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)Screenshots/Videos
Web
Screen.Recording.2022-12-07.at.11.15.07.AM.mov
Mobile Web - Chrome
NA; Unable to observe the network console
Mobile Web - Safari
NA; Unable to observe the network console
Desktop
Screen.Recording.2022-12-07.at.11.29.57.AM.mov
iOS
NA; Unable to observe the network console
Android
NA; Unable to observe the network console